This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate deployment manifest #242
Generate deployment manifest #242
Changes from 21 commits
b160d84
c659cc9
087e105
324c295
b7dda01
a20200b
100d61a
5e3a13a
6f120f0
63ecb40
db63b44
3dab91e
bd34428
e5c0607
d103026
f9f726f
7f4ec9d
238801e
d3b6e08
b3417e0
3a81665
4545be1
a63f382
94f93d3
cd13264
d7d47ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add the
rhdh-operator-*.yaml
to.gitignore
?Or I'm wondering if it wouldn't make sense to also commit and push this automatically (to a file like
deploy/rhdh-operator.yaml
)? Just like what we are already doing with the bundle manifests..This way, it would become even more straightforward to deploy the operator:
kubectl apply -f https://raw.githubusercontent.com/janus-idp/operator/main/deploy/rhdh-operator.yaml
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not like to suggest deploying "random" version from git repo in common case (it is good for ones who deal with sources but not sure for everyone else). I better add it to .gitignore as you suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the point is that this would not be random, but coming from the operator repo itself, so legitimate. Rather than having to deal with cloning the sources..
But anyway, fine for now to just Git-ignore it.
I think, for the future, this file could be generated and attached as a release artifact when we publish a new GH release.