Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

pin setup-envtest to fix test breakage #278

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

kim-tsao
Copy link
Member

Description

Current PR tests are failing due to this error:
go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240326031119-8afbb50e0eb2): go.mod:3: invalid go version '1.22.0': must match format 1.23

as a result of this change kubernetes-sigs/controller-runtime#2720 (comment)
We need to pin to an older commit in order to work around this.

Which issue(s) does this PR fix or relate to

  • Fixes #issue_number

PR acceptance criteria

  • Tests
  • Documentation
  • If the bundle manifests have been updated, make sure to review the rhdh-operator.csv.yaml file accordingly

How to test changes / Special notes to the reviewer

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot added the lgtm PR is ready to be merged. Required by Prow. label Mar 27, 2024
Copy link

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b37591b into janus-idp:main Mar 27, 2024
9 checks passed
@rm3l
Copy link
Member

rm3l commented Mar 27, 2024

/cherry-pick 1.1.x

Cherry-picking this in 1.1.x because PR tests on this branch are failing for the same reason.

@openshift-cherrypick-robot

@rm3l: new pull request created: #280

In response to this:

/cherry-pick 1.1.x

Cherry-picking this in 1.1.x because PR tests on this branch are failing for the same reason.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants