-
Notifications
You must be signed in to change notification settings - Fork 14
Fix E2E tests by changing the list of extra dynamic plugins added to examples/rhdh-cr-with-app-configs.yaml
#286
Conversation
…rhdh-cr-with-app-configs.yaml The plugins from '@dfatwork-pkgs' do not seem to work with the latest version of the Showcase image, as they prevent the Backstage process from starting correctly.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already addressed in #272
Please target it to 1.1.x
#272 is already big enough ^^, and adding more changes to it makes it even more difficult to review (already 100+ files changed). |
Well, even if we agreed to consider main as development branch, you requested that it must pass all e2e tests from the very initial state, that's what I am doing. |
Yep, for big PRs, tests help reviewers a lot to check the behavior. But alright, since I saw you cherry-picked the changes here in #272, let's close this one then. |
@rm3l: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
The plugins from
@dfatwork-pkgs/*
do not seem to work with the latest version of the Showcase image, as they prevent the Backstage process from starting correctly, making the Backstage pod crash.Which issue(s) does this PR fix or relate to
—
PR acceptance criteria
rhdh-operator.csv.yaml
file accordinglyHow to test changes / Special notes to the reviewer
make test-e2e
would not pass because ofexamples/rhdh-cr-with-app-configs.yaml
. Now runningmake test-e2e
should pass.