This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
ci: Run Integration Tests as part of PR checks #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
gazarenkov
suggested changes
May 27, 2024
There was a problem hiding this comment.
I think "make test" already included integration_tests, no?
Like:
ok redhat-developer/red-hat-developer-hub-operator/controllers 0.529s coverage: 22.8% of statements
ok redhat-developer/red-hat-developer-hub-operator/integration_tests 7.824s coverage: 42.2% of statements
ok redhat-developer/red-hat-developer-hub-operator/pkg/model 1.240s coverage: 84.6% of statements
🤔 Interesting.. I thought so initially, but they didn't seem to be included on my machine: |
They appear to be included in the CI, but I still am not sure why they are not on my machine. Closing this PR since they run in CI - will look into the local issue later. /close |
|
@rm3l: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the PR title suggests, this allows us to enforce that integration tests are run as part of the PR validation checks.
Currently, we are only running unit tests with
make test. In the past,make testused to cover a lot more via EnvTest, but this part has been moved to amake integration-testtarget since #272).As I almost always happen to run this target (along with the E2E tests) when reviewing PRs, I think we should enforce those integration tests as part of the automatic PR checks. Unlike the E2E tests, they don't take that long to run and do not require a cluster to run.
Which issue(s) does this PR fix or relate to
—
PR acceptance criteria
rhdh-operator.csv.yamlfile accordinglyHow to test changes / Special notes to the reviewer
Job passing: https://github.com/janus-idp/operator/actions/runs/9177666830/job/25235797784?pr=365