-
Notifications
You must be signed in to change notification settings - Fork 15
Remove deprecation warning about backend.auth.keys #390
Remove deprecation warning about backend.auth.keys #390
Conversation
…d.auth.keys Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Co-authored-by: 04kash <04kash@users.noreply.github.com>
|
@rm3l: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
…h/operator into remove-deprecation-warning
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Co-authored-by: 04kash <04kash@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine - thanks @04kash !! For the reasons mentioned in https://issues.redhat.com/browse/RHIDP-2716?focusedId=25057410&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-25057410, this PR will not be cherry-picked to 1.2.x
.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "PR Publish" Those jobs passed successfully, but for some reason, the status check was not reflected in the PR. |
@rm3l: Overrode contexts on behalf of rm3l: PR Publish, PR Validate In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Fixed default configuration to remove deprecation warning about backend.auth.keys by replacing it with https://github.com/backstage/backstage/blob/master/beps/0007-auth-external-services/README.md#the-legacy-access-type
Which issue(s) does this PR fix or relate to
Fixes: https://issues.redhat.com/browse/RHIDP-2716
PR acceptance criteria
rhdh-operator.csv.yaml
file accordinglyHow to test changes / Special notes to the reviewer