Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Remove deprecation warning about backend.auth.keys #390

Merged

Conversation

04kash
Copy link
Member

@04kash 04kash commented Jun 28, 2024

Description

Fixed default configuration to remove deprecation warning about backend.auth.keys by replacing it with https://github.com/backstage/backstage/blob/master/beps/0007-auth-external-services/README.md#the-legacy-access-type

Which issue(s) does this PR fix or relate to

Fixes: https://issues.redhat.com/browse/RHIDP-2716

PR acceptance criteria

  • Tests
  • Documentation
  • If the bundle manifests have been updated, make sure to review the rhdh-operator.csv.yaml file accordingly

How to test changes / Special notes to the reviewer

…d.auth.keys

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Co-authored-by: 04kash <04kash@users.noreply.github.com>
Copy link
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.
You might also need to manually update the .rhdh/bundle/manifests/rhdh-operator.csv.yaml CSV file accordingly.

@rm3l
Copy link
Member

rm3l commented Jul 1, 2024

@openshift-cherrypick-robot

@rm3l: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you.

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Co-authored-by: 04kash <04kash@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jul 2, 2024

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.
You might also need to manually update the .rhdh/bundle/manifests/rhdh-operator.csv.yaml CSV file accordingly.

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ci openshift-ci bot added the lgtm PR is ready to be merged. Required by Prow. label Jul 4, 2024
Copy link

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 4, 2024
@rm3l
Copy link
Member

rm3l commented Jul 4, 2024

/override "PR Publish"
/override "PR Validate"

Those jobs passed successfully, but for some reason, the status check was not reflected in the PR.

Copy link

openshift-ci bot commented Jul 4, 2024

@rm3l: Overrode contexts on behalf of rm3l: PR Publish, PR Validate

In response to this:

/override "PR Publish"
/override "PR Validate"

Those jobs passed successfully, but for some reason, the status check was not reflected in the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 83b7f91 into janus-idp:main Jul 4, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants