This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
chore: Switch the default operand image tag from latest to next and fix CI nightly job [RHIDP-3157]
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazarenkov
reviewed
Jul 16, 2024
There was a problem hiding this comment.
I am not a big fan testing "derivative" artifacts but since we do not release long living upstream binaries yet, I am OK with anything for resolving #399.
…owcase:latest' to 'quay.io/rhdh/rhdh-hub-rhel9:latest' 'quay.io/rhdh/rhdh-hub-rhel9' is the downstream image of the Showcase image
User authentication is now needed to query the '/api/dynamic-plugins-info/loaded-plugins' API endpoint
…ng v1alpha1 as version Otherwise, the 1.x operator is not aware of the v1alpha2 version
It should hopefully fix the random network connection issues
This will reduce the likeliness of random connectivity failures
rm3l
force-pushed
the
RHIDP-3157_issue-detected-with-nightly-e2e-checks
branch
from
69a4fc1
to
45d3630
Compare
|
The nightly job should now be fixed. See https://github.com/rm3l/janus-idp-operator/actions/runs/9954821654 |
rm3l
changed the title
quay.io/rhdh/rhdh-hub-rhel9:latest and fix CI nightly job [RHIDP-3157]
…stage-showcase:latest' to 'quay.io/rhdh/rhdh-hub-rhel9:latest'" This reverts commit 8b81157.
'next' is the development tag of the upstream Showcase image, and should hopefully be stable. The goal with this is to monitor how our tests behave against this 'next' tag. If it proves too unstable, we might want to switch back to using the downstream RHDH image (`quay.io/rhdh/rhdh-hub-rhel9:latest`).
rm3l
changed the title
quay.io/rhdh/rhdh-hub-rhel9:latest and fix CI nightly job [RHIDP-3157]latest to next and fix CI nightly job [RHIDP-3157]
gazarenkov
approved these changes
Jul 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gazarenkov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the failing nightly job by:
quay.io/janus-idp/backstage-showcase:latesttoquay.io/rhdh/rhdh-hub-rhel9:latestquay.io/janus-idp/backstage-showcase:next.We'll need to monitor our tests to see how they behave against this
nexttag (built from themainbranch of the Showcase repo). If they are too unstable, we might need to switch back to using a stable (and updated) downstream RHDH image./api/dynamic-plugins-info/loaded-pluginsendpoint (used in the tests to ensure a fully-working CR example)Which issue(s) does this PR fix or relate to
PR acceptance criteria
rhdh-operator.csv.yamlfile accordinglyHow to test changes / Special notes to the reviewer
See https://github.com/rm3l/janus-idp-operator/actions/runs/9960353647/job/27520205261 as an example of a successful run.