Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Multiple config profile #411

Closed
wants to merge 11 commits into from

Conversation

gazarenkov
Copy link
Member

Description

In order to be able to support different types of Backstage configuration (in contrary of having Operator to RHDH/Backstage Showcase only) Kustomize scripts (./config/*) and Makefile was reworked to support 2 types of configuration:

  • RHDH - default, nothing changed if you run the commands as it used to be
  • backstage.io - bare backstage, image on https://github.com/backstage/backstage/pkgs/container/backstage
  • there is also third experimental profile called "external", suppose to be used by third-party configuration (TBD later, just to mention why: mostly as a placeholder for the time)

So, now, it is possible to put PROFILE variable to related Make commands and test/run/deploy related configuration, e.g:

  • PROFILE=backstage.io make install run
  • PROFILE=backstage.io make test
  • PROFILE=backstage.io make deploy
  • ...

Which issue(s) does this PR fix or relate to

#47 (JIRA: https://issues.redhat.com/browse/RHIDP-1338)

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

Try to run commands with PROFILE=backstage.io and PROFILE=default (which is the same a no profile, i.e. RHDH).

NOTE: this PR is on a draft state, all the details are potential subject to change
NOTE2: Mind that in contrary to RHDH, deploying bare Backstage is faster than deploying PGSQL, so usually the container run with 3rd or so attempt (DB is not accessible).

Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
@gazarenkov gazarenkov requested review from kadel and rm3l July 24, 2024 10:01
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress PR should not merge because it is a draft or work in progress. Required by Prow. label Jul 24, 2024
Copy link

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gazarenkov. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress PR should not merge because it is a draft or work in progress. Required by Prow. needs-rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants