-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
Signed-off-by: gazarenkov <gazarenkov@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
In order to be able to support different types of Backstage configuration (in contrary of having Operator to RHDH/Backstage Showcase only) Kustomize scripts (./config/*) and Makefile was reworked to support 2 types of configuration:
So, now, it is possible to put PROFILE variable to related Make commands and test/run/deploy related configuration, e.g:
Which issue(s) does this PR fix or relate to
#47 (JIRA: https://issues.redhat.com/browse/RHIDP-1338)
PR acceptance criteria
How to test changes / Special notes to the reviewer
Try to run commands with PROFILE=backstage.io and PROFILE=default (which is the same a no profile, i.e. RHDH).
NOTE: this PR is on a draft state, all the details are potential subject to change
NOTE2: Mind that in contrary to RHDH, deploying bare Backstage is faster than deploying PGSQL, so usually the container run with 3rd or so attempt (DB is not accessible).