Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Add Audit Log PersistentVolume and PersistentVolumeClaim #412

Closed
wants to merge 2 commits into from

Conversation

coreydaley
Copy link
Member

@coreydaley coreydaley commented Jul 25, 2024

Description

Which issue(s) does this PR fix or relate to

  • Fixes #issue_number

PR acceptance criteria

  • Tests
  • Documentation
  • If the bundle manifests have been updated, make sure to review the rhdh-operator.csv.yaml file accordingly

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress PR should not merge because it is a draft or work in progress. Required by Prow. label Jul 25, 2024
@openshift-ci openshift-ci bot requested review from nickboldt and rm3l July 25, 2024 06:15
Copy link

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from coreydaley. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.
You might also need to manually update the .rhdh/bundle/manifests/rhdh-operator.csv.yaml CSV file accordingly.

@coreydaley coreydaley changed the title [WIP] Add Audit Log PersistentVolume and PersistentVolumeClaim Add Audit Log PersistentVolume and PersistentVolumeClaim Jul 25, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress PR should not merge because it is a draft or work in progress. Required by Prow. label Jul 25, 2024
Regenerate bundle manifests

Co-authored-by: coreydaley <coreydaley@users.noreply.github.com>
Co-authored-by: coreydaley <coreydaley@users.noreply.github.com>
Copy link
Contributor

⚠️ Files changed in bundle generation!

Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.
You might also need to manually update the .rhdh/bundle/manifests/rhdh-operator.csv.yaml CSV file accordingly.

Copy link

sonarcloud bot commented Jul 25, 2024

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gazarenkov gazarenkov added the do-not-merge/work-in-progress PR should not merge because it is a draft or work in progress. Required by Prow. label Jul 30, 2024
@nickboldt
Copy link
Member

As part of the migration from janus-idp to redhat-developer in https://issues.redhat.com/browse/RHIDP-1021, this will be closed. Please reopen it in the https://github.com/redhat-developer/rhdh-operator repo if it's still relevant, with a link to the associated JIRA.

@nickboldt nickboldt closed this Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress PR should not merge because it is a draft or work in progress. Required by Prow. needs-rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants