Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Optimize pod-refresh-on-external-config preprocessing and tests #414

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

gazarenkov
Copy link
Member

@gazarenkov gazarenkov commented Jul 29, 2024

Description

This pull request:

  • removes check for labels/annotations on hash calculation procedure avoiding extra creation of Deployment with checksum for "empty" config and -> unexpected additional Deployment update which should fix https://issues.redhat.com/browse/RHIDP-3217 (Backstage seems have the "concurrency" problem, starting up more than one instances)
  • fixes config-refresh tests. Looks like newer Backstage version become more strict to the app-config content (it can not be "any" anymore)
  • adds retry.RetryOnConflict for better experience (retrying with no error messages in log) when add extra labels/annotations on CM/Secret

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHIDP-3217

PR acceptance criteria

  • Tests

How to test changes / Special notes to the reviewer

  1. Run CR with specified CM/Secrets, no extra Pod should appear on start time, no extra "CM/Secret version conflict" Log records show up
  2. integration_tests/config-refresh_test should pass.

Signed-off-by: gazarenkov <gazarenkov@gmail.com>
Copy link

sonarcloud bot commented Jul 29, 2024

@openshift-ci openshift-ci bot added the lgtm PR is ready to be merged. Required by Prow. label Jul 30, 2024
Copy link

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c9e27da into janus-idp:main Jul 30, 2024
8 checks passed
@gazarenkov gazarenkov deleted the pod-refresh-preproc branch August 6, 2024 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants