Clean up untested methods #2
Conversation
|
Hi Jan! 新年快乐! I'm just getting around to writing a pull request to get this gem used in ruby-ethereum(it's already used in ruby-eth). To start I went through the gem, cleaning it up, kind of following your suggestion of only putting pieces in that are needed. With a bit more context on what everything does, I began to wonder if this is really a necessary gem. For the most part it seems to mainly be wrappers around RLP and SHA3, with a couple more helper methods for coercing between different formats. What do you think? I am still happy to write the pull request for ruby-ethereum if you are open to it, but I'm beginning to wonder if will be worth the coordination long term. Maybe a little duplication is not the worst thing if it eliminates the complexity of spreading the code across so many repositories. Are there other functions you imagine being pulled out into this gem? Apologies for taking so long to get around to this. Hope you're doing well. |
|
@se3000 新年快乐! 🐓 I agree it may not worth it at this stage, there's higher priority tasks. As you can tell we lack contributors, ruby-ethereum can barely keep up with other clients, let alone ruby-devp2p and reth (both never finished). I'd like to see more effort on ruby-ethereum itself. There're a lot of things to do:
If you're interested let me know, I'm happy to answer any questions :-) |
This pull request cleans up some of the methods that were not tested, and so seemingly unused. Fixes various problems like referring to classes and constants that didn't exist, which I missed at the first pass of originally pulling this out of ruby-ethereum. Additionally adds some tests, and a related missing function for some useful methods.
This is really just supposed to clean up the gem, as it was pulled out rather quickly initially.