New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build compiler_builtins by default? #212

Closed

phil-opp opened this issue Apr 8, 2018 · 0 comments · Fixed by #213

phil-opp commented Apr 8, 2018

With rust-lang/rust#49503 the compiler_builtins crate is injected to no_std crates by default. Thus, a Xargo.toml that builds compiler_builtins is always required now (see rust-lang/rust#49503 (comment)). Would it make sense to update xargo default to build compiler_builtins even without a Xargo.toml?

The text was updated successfully, but these errors were encountered:

phil-opp changed the title ~~Build compiler_builtins by default~~ Build compiler_builtins by default?

japaric mentioned this issue

compile core and compiler_builtins (+mem) ... #213

Merged

bors bot added a commit that referenced this issue


          Merge #213

bfb1efd

213: compile core and compiler_builtins (+mem) ... r=japaric a=japaric

if no Xargo.toml was specified

closes #212

cc @phil-opp

Co-authored-by: Jorge Aparicio <jorge@japaric.io>

bors bot added a commit that referenced this issue


          Merge #213

3bd678d

213: compile core and compiler_builtins (+mem) ... r=japaric a=japaric

if no Xargo.toml was specified

closes #212

cc @phil-opp

Co-authored-by: Jorge Aparicio <jorge@japaric.io>

bors bot added a commit that referenced this issue


          Merge #213

0b14fda

213: compile core and compiler_builtins (+mem) ... r=japaric a=japaric

if no Xargo.toml was specified

closes #212

cc @phil-opp

Co-authored-by: Jorge Aparicio <jorge@japaric.io>

bors bot added a commit that referenced this issue


          Merge #213

97788be

213: compile core and compiler_builtins (+mem) ... r=japaric a=japaric

if no Xargo.toml was specified

closes #212

cc @phil-opp

Co-authored-by: Jorge Aparicio <jorge@japaric.io>

bors bot added a commit that referenced this issue


          Merge #213

440e48f

213: compile core and compiler_builtins (+mem) ... r=japaric a=japaric

if no Xargo.toml was specified

closes #212

cc @phil-opp

Co-authored-by: Jorge Aparicio <jorge@japaric.io>

bors bot closed this as completed in #213

denzp mentioned this issue

Error building chapter-1: can't find crate for compiler_builtins denzp/rust-ptx-builder#3

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment