Copy bin directory to host sysroot #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @FenrirWolf bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 9, 2018
200: Copy bin directory to host sysroot r=japaric a=FenrirWolf Allows custom targets to use the copy of `lld` bundled with Rust. cc rust-lang/rust#48772
Build succeeded |
|
I just tried it and it seems to work! Thanks a lot @FenrirWolf! @japaric Could we get a new crates.io release for this? |
|
@phil-opp v0.3.11 is out and has these changes |
|
Thanks a lot! |
This was referenced Mar 9, 2018
|
Could you please upload binaries for 0.3.11 to https://github.com/japaric/xargo/releases? I'm using your install.sh script to pull the latest tag and CI is failing as the tag exists, but binaries don't. Happy to help doing that as well if you point me in the right direction. |
|
@ah- done. Linux releases have been uploaded. |
|
That was quick! Thanks, works perfectly again. |
|
I had to update my rust nightly as well as install the new xargo to get this to work, but it works for me too! |
Merged
bors bot
added a commit
that referenced
this pull request
Mar 26, 2018
201: Update Cargo.lock r=japaric a=Woyten Since #200, `Cargo.lock` is considered dirty after Xargo has been built. This is particularly annoying when using Xargo as a Git submodule such as in tock/libtock-rs#18. This PR updates `Cargo.lock` s.t. it will no longer be considered dirty after building Xargo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows custom targets to use the copy of
lldbundled with Rust.cc rust-lang/rust#48772