Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce complexity in Selector._setSelectorText #51

Merged
merged 7 commits into from
May 14, 2024
Merged

Reduce complexity in Selector._setSelectorText #51

merged 7 commits into from
May 14, 2024

Commits on May 14, 2024

  1. Use contextlib.suppress

    @jaraco
    jaraco committed May 14, 2024
    Configuration menu
    Copy the full SHA
    253fd24 View commit details
    Browse the repository at this point in the history

  2. Short circuit and reduce indentation.

    @jaraco
    jaraco committed May 14, 2024
    Configuration menu
    Copy the full SHA
    cec52e3 View commit details
    Browse the repository at this point in the history

  3. Extract _prepare_tokens

    @jaraco
    jaraco committed May 14, 2024
    Configuration menu
    Copy the full SHA
    4775886 View commit details
    Browse the repository at this point in the history

  4. Move the 'New' object into a dataclass.

    @jaraco
    jaraco committed May 14, 2024
    Configuration menu
    Copy the full SHA
    80af16b View commit details
    Browse the repository at this point in the history

  5. Moved append function into 'New' class.

    @jaraco
    jaraco committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8afae87 View commit details
    Browse the repository at this point in the history

  6. Moved productions into the 'New' class (and constants into their own … 

    …class).
    @jaraco
    jaraco committed May 14, 2024
    Configuration menu
    Copy the full SHA
    cd435f7 View commit details
    Browse the repository at this point in the history

  7. Remove 'else' clauses; none of the 'if' clauses fall through.

    @jaraco
    jaraco committed May 14, 2024
    Configuration menu
    Copy the full SHA
    bde08c8 View commit details
    Browse the repository at this point in the history