Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations #14

Open
bswck opened this issue Nov 3, 2023 · 5 comments
Open

Add type annotations #14

bswck opened this issue Nov 3, 2023 · 5 comments

Comments

@bswck
Copy link
Contributor

bswck commented Nov 3, 2023 •
edited
Loading

jaraco/collections.py → jaraco/collections/__init__.py + jaraco/collections/__init__.pyi + jaraco/collections/py.typed
Similarly as in this pull request, having in mind all the caveats encountered that time.
@bswck
Copy link
Contributor Author

bswck commented Nov 3, 2023

A PR will appear in some time.

@bswck
Copy link
Contributor Author

bswck commented Dec 8, 2023

This change would contribute to jaraco/skeleton#98.

jaraco added a commit that referenced this issue Dec 9, 2023
@jaraco
Moved collections into a package and declared as typed.
0e57eb4 
Ref #14
@jaraco
Copy link
Owner

jaraco commented Dec 9, 2023

In 0e57eb4, I've done the rename and type declaration. I'll leave it to you to implement the stubs.

@bswck
Copy link
Contributor Author

bswck commented Dec 9, 2023

Thanks! I've just opened the project locally and I can see that the stub is mostly done. This should be quick!

@bswck bswck moved this to Todo in Typing Initiative Feb 7, 2024
@Avasam
Copy link
Contributor

Avasam commented Jul 27, 2024 •
edited
Loading

With Python 3.8 as the minimal supported version, I doubt a stub is needed. Inline types are fine.

@jaraco jaraco changed the title Make jaraco.collections a package and add a stub file Add type annotations Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaraco @Avasam @bswck