py.typed and strictly type-checked
#3
Conversation
jaraco/compat/py38.py
Outdated
| if sys.version_info < (3, 9): # pragma: no cover | ||
| cache = functools.lru_cache(maxsize=None) | ||
| r_fix = _fixer | ||
| else: | ||
| cache = functools.cache | ||
|
|
||
| cache = ( | ||
| functools.cache # type: ignore[attr-defined] | ||
| if sys.version_info >= (3, 9) | ||
| else functools.lru_cache(maxsize=None) | ||
| ) | ||
| def r_fix(orig: str) -> str: | ||
| return orig |
There was a problem hiding this comment.
I do prefer to have single assignment rather than conditional assignment. I also like to keep concerns separate. With this change, now r_fix and cache is interleaved.
But I see now why you do it - mypy doesn't honor conditionals that aren't conditional blocks.
The problem with accepting this change is I'm already tempted to refactor it to separate the concerns and consolidate assignments.
I think this is a case where the value of the original logic is greater than the value of the type checking.
Restored in 67d3f31.
There was a problem hiding this comment.
It's definitely a balance of what you value!
Pyright understands "ternary" (conditional expression), by not mypy https://github.com/python/mypy/issues?q=sort%3Aupdated-desc+is%3Aopen+label%3Atopic-ternary-expression (the most specific issue/request related to this case would be python/mypy#13003 )
Generally as long as the exposed type is correct.
Ref: jaraco/skeleton#143
Such a small repo, it was basically already there.