Fix build: rumps is a macos only dependency #3
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Sep 18, 2024
| if sys.platform != "darwin": | ||
| print("This app is only available on MacOS.") | ||
| sys.exit(1) | ||
| assert False # https://github.com/python/mypy/issues/9025#issuecomment-1087270212 |
There was a problem hiding this comment.
Avasam
force-pushed
the
fix-build-trap-watcher-macos-only
branch
from
cd59d6a
to
23c3748
Compare
|
Python 3.14 install failing because prebuilt lxml wheels are (unsurprisingly) not available and manual build fails due to missing system dependencies. I think that can be ignored (or excluding 3.14 in a different PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.