Pass mypy and link issues #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Pass-mypy-and-link-issues
branch
from
afd89ab
to
d27c74d
Compare
Avasam
commented
Nov 25, 2024
Comment on lines
-7
to
+9
| res = WNetAddConnection2(resource, UserName=username) | ||
| res = WNetAddConnection2(resource, UserName=username) # type: ignore[func-returns-value] # python/typeshed#12595 | ||
| print('first result is', res) | ||
| res = WNetAddConnection2(resource, UserName=username) | ||
| res = WNetAddConnection2(resource, UserName=username) # type: ignore[func-returns-value] # python/typeshed#12595 |
There was a problem hiding this comment.
This file has been removed by c5cfffb anyway, but for posterity I wanna say that WNetAddConnection2 never actually returns anything anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: jaraco/skeleton#143
Upstream issues:
symlinkfallback injaraco/windows/bugs/vista-symlink-islink-bug.pyhas invertedtargetandlinkparam compared tojaraco.windows.filesystem.symlink#27py.typedjaraco.text#17py.typedjaraco.structures#2jaraco/skeletonbased projects python/typeshed#12595This does changes some imports with the assumption that older Python versions are no longer supported.