Deprecate empty usernames #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jaraco
commented
Aug 1, 2024
jaraco
commented
- Add a test capturing the missed expectation. Ref Support for empty string usernames is inconsistent #668.
- Mark the test as xfail where it's failing (Windows).
- Deprecate setting a password for an empty username.
- Extract method for registration.
- When constructing KeyringBackend subclasses, wrap set_password to enforce non-empty usernames.
…orce non-empty usernames.
|
Tests on diffcov are failing, but only because the coverage reports aren't aggregated (jaraco/skeleton#130). |
There will be an issue link generated, right? |
Yes. It will link to #668 in the changelog (from the 668.feature.rst file). |
mitya57
approved these changes
Aug 2, 2024
abn
added a commit
to abn/poetry
that referenced
this pull request
Nov 16, 2024
abn
added a commit
to abn/poetry
that referenced
this pull request
Nov 16, 2024
abn
added a commit
to abn/poetry
that referenced
this pull request
Nov 17, 2024
abn
added a commit
to abn/poetry
that referenced
this pull request
Nov 17, 2024
abn
added a commit
to abn/poetry
that referenced
this pull request
Nov 17, 2024
abn
added a commit
to abn/poetry
that referenced
this pull request
Nov 17, 2024
abn
added a commit
to abn/poetry
that referenced
this pull request
Nov 17, 2024
abn
added a commit
to python-poetry/poetry
that referenced
this pull request
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.