Feature/ch5790/icon comp props

[galimpian]

No description provided.

[jeremy-farnault]

Hey,

Thanks for the PR.
I won't merge it as it is because you're completely removing the default material solution.
I like the idea of the customization but I also want people to have a something that they can use without having to provide a component. So I'd do it by leaving the material one but displaying it only if your new prop is not there.

I have changed this and published v1.41.0 with the changes.

Tell me if it's ok.

Cheers,
Jeremy

[galimpian]

Hi Jeremy, I hope the idea will be useful to others, thanks for including the code! Best, Galina

…

On Wed, Jun 26, 2019 at 7:51 PM Jérémy Farnault ***@***.***> wrote: Hey, Thanks for the PR. I won't merge it as it is because you're completely removing the default material solution. I like the idea of the customization but I also want people to have a something that they can use without having to provide a component. So I'd do it by leaving the material one but displaying it only if your new prop is not there. I have changed this and published v1.41.0 with the changes. Tell me if it's ok. Cheers, Jeremy — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#100?email_source=notifications&email_token=AJ5IPCXAM5WZL2OC4FTWHELP4P6GVA5CNFSM4H3MJ6C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYVD6UA#issuecomment-506085200>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJ5IPCSM34EEPC77UX6YDD3P4P6GVANCNFSM4H3MJ6CQ> .

-- Thank you, Galina Nosti UX Engineer

[anis-18]

It's still not working on Android and showin console error on iOS is there any solution ?