Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying after content issue #43

Closed
samikeijonen opened this issue May 19, 2016 · 3 comments
Closed

Displaying after content issue #43

samikeijonen opened this issue May 19, 2016 · 3 comments

Comments

@samikeijonen
Copy link

samikeijonen commented May 19, 2016

First, thank you for great plugin!

I have noticed one issue in several sites where I use the plugin. When I set Theme Location to After content or Before and After Content, social sharing buttons always remain before the content.

If I set Before and After Content, I get sharing button twice before the content.

screenshot 2016-05-19 13 55 14

I tried to check the code but didn't notice any problems and run out of time.

I'm using regular _s based theme, not Genesis or Theme Hook Alliance.

@samikeijonen
Copy link
Author

Also got the same issue using Twenty 16.

@billerickson
Copy link
Collaborator

In the display functions we have can either echo the share buttons (if using a hook) or return the share buttons (if using a filter). The logic was messed up so it always echoed. This resulted in the share buttons appearing before the post content regardless of selected theme location if you were using the filter.

@samikeijonen
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants