Add semicolon to source-map-support banner to fix 'require() is not a function' error #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept running into this error when executing my code that was bundled by Backpack:
After some digging, I realized that it's a simple fix. Here's what's being generated on
master
:Node interprets this as passing the webpack output into the result of
require()
as an argument. If we change the banner to this fixes the issue (note the semicolon):This patch just adds that semicolon to the banner that's included at the top of the bundle. I'm not sure if there's just something strange about my Webpack config that makes this happen. However, there's no downside to adding the semicolon, so even if I've hit an edge case it seems like a good change.