-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: Align FormikHelpers and FieldHelper types to useFormik ones #3843
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
da9f129
Align FormikHelpers types to useFormik ones
bonimba 194d13b
Align FieldHelperProps types to useFormik ones
bonimba 16b599e
update docs
bonimba b770e8e
add changeset as patch
bonimba 4adda22
Merge branch 'main' into cohesive-types
bonimba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'formik': patch | ||
--- | ||
|
||
Fix FormikHelper and FieldHelperProps types |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,12 +86,12 @@ export interface FormikHelpers<Values> { | |
setTouched: ( | ||
touched: FormikTouched<Values>, | ||
shouldValidate?: boolean | ||
) => void; | ||
) => Promise<void | FormikErrors<Values>>; | ||
/** Manually set values object */ | ||
setValues: ( | ||
values: React.SetStateAction<Values>, | ||
shouldValidate?: boolean | ||
) => void; | ||
) => Promise<void | FormikErrors<Values>>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
/** Set value of form field directly */ | ||
setFieldValue: ( | ||
field: string, | ||
|
@@ -105,11 +105,11 @@ export interface FormikHelpers<Values> { | |
field: string, | ||
isTouched?: boolean, | ||
shouldValidate?: boolean | ||
) => void; | ||
) => Promise<void | FormikErrors<Values>>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
/** Validate form values */ | ||
validateForm: (values?: any) => Promise<FormikErrors<Values>>; | ||
/** Validate field value */ | ||
validateField: (field: string) => void; | ||
validateField: (field: string) => Promise<void> | Promise<string | undefined>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
/** Reset form */ | ||
resetForm: (nextState?: Partial<FormikState<Values>>) => void; | ||
/** Submit the form imperatively */ | ||
|
@@ -302,9 +302,9 @@ export interface FieldMetaProps<Value> { | |
/** Imperative handles to change a field's value, error and touched */ | ||
export interface FieldHelperProps<Value> { | ||
/** Set the field's value */ | ||
setValue: (value: Value, shouldValidate?: boolean) => void; | ||
setValue: (value: Value, shouldValidate?: boolean) => Promise<void | FormikErrors<Value>>; | ||
/** Set the field's touched value */ | ||
setTouched: (value: boolean, shouldValidate?: boolean) => void; | ||
setTouched: (value: boolean, shouldValidate?: boolean) => Promise<void | FormikErrors<Value>>; | ||
/** Set the field's error value */ | ||
setError: (value: string | undefined) => void; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.