Update for compatibility with Jest 22.0.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, as always thank for the speedy merge! Would it be possible to cut a new release for this? |
|
Done! |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating a project using this serialiser to use Jest 22.0.0, I saw that snapshot tests were being broken by extra, nested prints of the styles.
It seems as though the
serializefunction Jest passes to theprintfunction has new behaviour in Jest 22, and includes the current serialiser with it.My solution was to reset the
stylesvariable before creating the printed result, and to make a copy of it beforehand. This means the styles aren't printed in the subsequent serialisations inserialize(val), and gives us the added bonus of stripping some newlines where they're not necessary.Seems that Jest uses different names for snapshots now, so they changed a lot — sorry about that! Please let me know if there's anything else that needs tidying up. Thanks!