-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js 8.0.0+ compatibility issue #287
Comments
This line comes directly from https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/config/webpack.config.dev.js#L89 Can you try the latest create-react-app to see if you have the same issue? |
I see. Sure, now I have tested it and create-react-app works with both versions of Node.js. |
Also I have used create-react-app as a global module, but I always use razzle as a local module. |
I don't have a way to test this out unfortunately. I don't own a Windows PC. 😢 |
I see. So this issue doesn't occurs on your Mac? It is possible to use Windows in a virtual box. Running the following code using the Node.js console console.log(process.env.NODE_PATH) I am getting the following output: undefined
undefined Is this the expected behavior? Also accourding to Razzle's source code it is not really possible that the |
Just tested, that in create-react-app |
So you have the same issue with create-react-app, but not with Razzle? |
Nope. They have identical behavior because the code that handles NODE_PATH is copied directly CRA https://github.com/jaredpalmer/razzle/blob/master/packages/razzle/config/env.js#L46 |
I see. In env.js it is definitely Interestingly if I console log it in create-config.js like this: console.log(process.env.NODE_PATH) Than I get this result: $ razzle start
WAIT Compiling...
undefined
undefined
DONE Compiled successfully
... So the server starts successfully. Do you think I should report this issue at @facebookincubator's create-react-app as well? |
Yes |
Well, create-react-app now works for me with Node.js 8. |
Maybe code using |
@kireerik What happens if you set {
...
"scripts": {
"start": "NODE_PATH=src razzle start",
"test": "NODE_PATH=src razzle test",
...
}
} |
It works that way if I do it correctly like this: |
@gaearon does CRA use cross-env under the hood? |
|
@jaredpalmer No (it doesn't launch processes for build/start unless I misunderstand something). We assing |
replace NODE_PATH with PATH like |
same issues here
|
Looks like it's a race-condition, created a PR with the fix. |
Thank you @stoikerty! I couldn't spot the root cause of this issue. It was so strange to me. |
Wooo!!! |
Sorry, I thought this issue is resolved by now. At least it is working for me with the latest pre-release. Am I wrong with that? |
Pressed the wrong button. ;) |
Have the same issue. Only |
I have installed Node.js 8.0.0 under Windows 10 and I am getting the following errors when I am using the
razzle start
command:I am getting a similar error for
razzle build
as well.With Node.js 7.10.0 it worked and it still works if I install it back.
The text was updated successfully, but these errors were encountered: