Fix node path usage

[stoikerty]

Hey Jared,

On my exploration through razzle I stumbled over this compatibility issue. The culprit is a race-condition which I fixed by replacing the use of the process.env.NODE_PATH-global with an exported variable. Not sure why it only happens on windows, must have something to do with how Node handles imports/exports and envs in that OS.

It was already working like this:

// packages/razzle/config/createConfig.js
// ...
const getEnv = require('./env');

const nodePath = process.env.NODE_PATH;

module.exports = (
// ...
      modules: ['node_modules', paths.appNodeModules].concat(
        nodePath.split(path.delimiter).filter(Boolean)
      )
// ...

but I thought that having a dangling variable there would be confusing, therefore I opted to reduce the reliance on the relevant global entirely.

Love the concept of razzle btw, great stuff 👍

[jaredpalmer]

Yasss! This is dope.