Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility for Build to use NODE_ENV before defaulting #556

Closed
wants to merge 1 commit into from
Closed

Conversation

fede
Copy link

@fede fede commented Mar 26, 2018

NODE_ENV was hardcoded to 'production'. This made it impossible to set staging, integration or any other NODE_ENV.

@annez
Copy link

annez commented Apr 12, 2018

I completely agree with this change, builds shouldn't be hardcoded to any sort of environment because people choose to name things differently, and in most environments you will have a staging as well. Unless @jaredpalmer you suggest doing this another way for, say, a URL config map of API endpoints?

We have things like:

{
   "production": "https://foo",
   "staging": "https://bar",
   "default": "localhost"
}

These URLs are shared across both client and server, and currently we cannot use the same environment variable to generate the right builds before running this.

@jaredpalmer
Copy link
Owner

Closed in favor of #611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants