Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deploy Playground] Fix Netlify build command #207

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

netzwerg
Copy link
Contributor

Lib needs to be built to dist before example can be built ("Cannot resolve dependency '../../dist'")

Lib needs to be built to `dist` before example can be built ("Cannot resolve dependency '../../dist'")
@swyxio
Copy link
Collaborator

swyxio commented Sep 11, 2019

hmm. netlify should already do the initial yarn for you. no reason to do it twice. what are you seeing?

@netzwerg
Copy link
Contributor Author

Strange. As mentioned, I'm seeing:

10:28:47 AM: [4/4] Building fresh packages...
10:28:48 AM: Done in 27.03s.
10:28:49 AM: yarn run v1.17.0
10:28:49 AM: $ parcel build index.html
10:29:11 AM: 🚨  /opt/build/repo/example/src/App.tsx:29:21: Cannot resolve dependency '../../dist' at '/opt/build/repo/dist'
10:29:11 AM:     at Resolver.resolve (/opt/build/repo/example/node_modules/parcel/src/Resolver.js:71:17)
10:29:11 AM: error Command failed with exit code 1.

full log

@swyxio
Copy link
Collaborator

swyxio commented Sep 11, 2019

ah. this probably means you need to build the LIBRARY first before building the EXAMPLE. i get it now.

@swyxio swyxio merged commit 24a1fdc into jaredpalmer:master Sep 11, 2019
@agilgur5
Copy link
Collaborator

@allcontributors please add @netzwerg for docs

@allcontributors
Copy link
Contributor

@agilgur5

I've put up a pull request to add @netzwerg! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants