Skip to content

Commit

Permalink
Fix log contention issue
Browse files Browse the repository at this point in the history
This fixes another log contention issue we were seeing in CI. This was
not caught in dotnet#72263 because the syntax generation only ran
conditionally hence masked this problem.
  • Loading branch information
jaredpar committed Mar 6, 2024
1 parent 3ae3ef9 commit 98fbe53
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
1 change: 0 additions & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@ stages:
- pwsh: |
./eng/generate-compiler-code.ps1 -test -configuration Release
displayName: Generate Syntax Files
condition: or(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['compilerChange'], 'true'))
- pwsh: |
./eng/validate-code-formatting.ps1 -ci -rootDirectory $(Build.SourcesDirectory)\src -includeDirectories Compilers\CSharp\Portable\Generated\, Compilers\VisualBasic\Portable\Generated\, ExpressionEvaluator\VisualBasic\Source\ResultProvider\Generated\
Expand Down
16 changes: 6 additions & 10 deletions eng/validate-rules-missing-documentation.ps1
Original file line number Diff line number Diff line change
@@ -1,30 +1,26 @@
[CmdletBinding(PositionalBinding=$false)]
param (
[switch]$ci
[switch]$ci = $false
)

Set-StrictMode -version 2.0
$ErrorActionPreference="Stop"


Write-Host "Building Microsoft.CodeAnalysis.Features"
try {
. (Join-Path $PSScriptRoot "build-utils.ps1")
Push-Location $RepoRoot
$prepareMachine = $ci

$projectFilePath = Join-Path $RepoRoot "src\Features\Core\Portable\Microsoft.CodeAnalysis.Features.csproj"
Exec-DotNet "build $projectFilePath -t:GenerateRulesMissingDocumentation -p:RoslynEnforceCodeStyle=false -p:RunAnalyzersDuringBuild=false -p:ContinuousIntegrationBuild=$ci -c Release"

if ($LASTEXITCODE -ne 0) {
Write-Host "Failed with exit code $LASTEXITCODE."
exit $LASTEXITCODE
}
}
catch {
Write-Host "Error verifying rules missing documentation!"
Write-Host $_
Write-Host $_.Exception
Write-Host $_.ScriptStackTrace
$host.SetShouldExit(1)
exit 1
ExitWithExitCode 1
}
finally {
Pop-Location
}

0 comments on commit 98fbe53

Please sign in to comment.