An option to change the translated file's extension #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2020 15:25
useful, for example, if you are transpiling a .ts, .jsx or .tsx file into .js.
glebfrank
changed the title
milpol
requested changes
Jul 13, 2020
| if (babelMojo.getTargetFileExtension() != null) | ||
| targetFileName = targetFileName.replaceFirst("\\.[^./]+$", "."+babelMojo.getTargetFileExtension()); | ||
|
|
||
| return babelMojo.getTargetDir().toPath().resolve(relativePath).resolve(targetFileName); |
There was a problem hiding this comment.
Minor thing, please use brackets for if statement.
Could you introduce some tests for this? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transpiling a .ts, .jsx, or .tsx file, the resulting file's extension normally gets changed to .js (e.g., the input is in typescript, but the output is in plain javascript.) This plugin currently leaves the extension as is. I am proposing an option to set the translated files' extensions to a given string, e.g. "js".