Skip to content

Commit

Permalink
Fix pylint issue with python 3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
@jarun
jarun committed Dec 29, 2020
1 parent 3494d36 commit 9153f83
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/.pylintrc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ disable=
ungrouped-imports,
unidiomatic-typecheck,
unnecessary-lambda,
unsubscriptable-object,
unsupported-assignment-operation,
unused-argument,
unused-variable,
Expand Down

9 comments on commit 9153f83

@jarun
Copy link
Owner Author

@jarun jarun commented on 9153f83 Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dilawar, @eclipseo, @pabloariasal, @szlin, @rachmadaniHaryono, @jpdasma

buku v4.5 is released!

@rachmadaniHaryono
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pypi.org/project/buku/4.5/

@jarun
Copy link
Owner Author

@jarun jarun commented on 9153f83 Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@szlin
Copy link
Collaborator

@szlin szlin commented on 9153f83 Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jarun, I'm curious that have you passed the unit test with this version?
I met a timeout issue [1] when executing a unit test of test_bukuDb.py, it works well in the previous version.

[1] https://salsa.debian.org/debian/buku/-/jobs/1293301

@rachmadaniHaryono
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run it with durations flag

https://docs.pytest.org/en/latest/usage.html#profiling-test-execution-duration

for comparison travis ci python3.9 top 3 slowest test are these

https://app.circleci.com/pipelines/github/jarun/buku/274/workflows/8a866d71-6573-4779-8757-918f1b7c0b80/jobs/1197

80.26s call     tests/test_bukuDb.py::test_print_rec_hypothesis
2.88s call     tests/test_bukuDb.py::test_list_tags
1.71s call     tests/test_bukuDb.py::TestBukuDb::test_search_and_open_all_in_browser

and the test section only run under 3 minutes there

@szlin
Copy link
Collaborator

@szlin szlin commented on 9153f83 Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some investigation, I found the root cause is that the current pytest version in the SID archive is too old (4.6.11). The new version of pytest is in the experimental archive and is expected to migrate to the SID archive soon.

Sorry for the noise, the new version of buku has been uploaded.

@jarun
Copy link
Owner Author

@jarun jarun commented on 9153f83 Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lin!

@eclipseo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated on Fedora 32 to 34.

@jarun
Copy link
Owner Author

@jarun jarun commented on 9153f83 Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachmadaniHaryono can you please check the nightly failure: https://app.circleci.com/pipelines/github/jarun/buku/277/workflows/44369070-4aaa-4f2d-be17-391dbc3ff453

Please sign in to comment.