-
-
Notifications
You must be signed in to change notification settings - Fork 294
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
5 changed files
with
30 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eclipseo, @maxice8, @pabloariasal, @szlin, @rachmadaniHaryono, @jpdasma Buku v4.2 is released!
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @dilawar in case you are maintaining
Buku
on openSUSE. Released v4.2 today.cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarun done for Alpine Linux. I won't be maintaining it on Void Linux anymore (effective for all projects)
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Thank you!
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failure. Some tests are failing.
Logs: https://build.opensuse.org/package/live_build_log/home:dilawar:branches:devel:languages:python/python-buku/openSUSE_Tumbleweed/x86_64
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have removed support for python 3.4 which is EOL. Maybe because of that?
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, there is typeerror with string contenation
i will add fix+test for that
it is weird circleci don't catch this
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make a new dot release.
How do we ensure this doesn't happen again? Any check to be added in CircleCi?
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to 4.2 in Fedora 29-Fedora 31.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think once the patch is in, only platforms where packaging fails can update to the new release. For others, the 4.2 release should be fine.
@rachmadaniHaryono what do you say?
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dilawar I have merged @rachmadaniHaryono's fix. Can you check if your build passes with latest master?
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm making a new release 4.2.1. Wait for the announcement.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dilawar @rachmadaniHaryono 4.2.1 is released. Check if this works for you.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest pass on my local machine, so i upload it
https://pypi.org/project/buku/4.2.1/
fix #376
e: i will check circleci test later. my plan is (1) try to run setup.py before testing, maybe cache problem (2) enable travis as duplicate backup check
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building fine now.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update guys! @dilawar you can publish 4.2.1 on openSUSE.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guys, from #380 it looks like our prompt is broken in certain cases. I've reverted the original change but this is a nasty breakage.
To counter this I am considering making a minor release 4.2.2 which everyone can update in their channels. This is quite embarrassing for me and I apologize for the mess but I don't see another way out.
Please let me know your opinion.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dilawar I don't think Buku is available in the official opensuse repos. Can you see how we can submit it there?
It doesn't show on repology to be more precise.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd302c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you!