Skip to content

Commit

Permalink
Prepare for release v4.7
Browse files Browse the repository at this point in the history
  • Loading branch information
@jarun
jarun committed Jul 1, 2022
1 parent f499a63 commit da64fdd
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 3 deletions.
15 changes: 15 additions & 0 deletions CHANGELOG
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
buku v4.7
2022-07-01

- support XBEL export/import (#569)
- support for Microsoft Edge bookmarks (#585)
- block web fetch on import
- many bukuserver fixes (#543, #545, #547, #548, #553, #554, #559)
- import nested directory names as tags on html import (#539)
- fix slow/failed markdown import (#538)
- fix SSL certificate identification not working on macOS (#528)
- import tags from markdown (#523)
- fix broken pipe error with oil (#520)

-------------------------------------------------------------------------------

buku v4.6
2021-06-16

Expand Down
4 changes: 2 additions & 2 deletions buku
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ try:
except ImportError:
TypedDict = None # type: ignore

__version__ = '4.6'
__version__ = '4.7'
__author__ = 'Arun Prakash Jana <engineerarun@gmail.com>'
__license__ = 'GPLv3'

Expand Down Expand Up @@ -95,7 +95,7 @@ COLORMAP = {k: '\x1b[%sm' % v for k, v in {
'x': '0', 'X': '1', 'y': '7', 'Y': '7;1', 'z': '2',
}.items()}

USER_AGENT = 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0'
USER_AGENT = 'Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0'
MYHEADERS = None # Default dictionary of headers
MYPROXY = None # Default proxy
TEXT_BROWSERS = ['elinks', 'links', 'links2', 'lynx', 'w3m', 'www-browser']
Expand Down
2 changes: 1 addition & 1 deletion buku.1
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.TH "BUKU" "1" "16 Jun 2021" "Version 4.6" "User Commands"
.TH "BUKU" "1" "1 Jul 2022" "Version 4.7" "User Commands"
.SH NAME
buku \- Bookmark manager like a text-based mini-web
.SH SYNOPSIS
Expand Down

10 comments on commit da64fdd

@jarun
Copy link
Owner Author

@jarun jarun commented on da64fdd Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dilawar, @eclipseo, @pabloariasal, @szlin, @rachmadaniHaryono, @jpdasma

buku v4.7 is released! Please do the needful.

@rachmadaniHaryono
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i package the wrong commit 074e274

i will try to reupload to pypi and report back when it finished

@rachmadaniHaryono
Copy link
Collaborator

@rachmadaniHaryono rachmadaniHaryono commented on da64fdd Jul 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can delete the release but i cant post the same version

from their warning page

Warning This action cannot be undone!

You will not be able to re-upload a new distribution of the same type with the same version number.

Deletion will break any downstream projects relying on a pinned version of this package. It is intended as a last resort to address legal issues or remove harmful releases.

Consider [yanking](https://pypi.org/help/#yanked) this release, making a new release or a [post release](https://pypi.org/manage/project/buku/releases/#delete_release-modal-1) instead.

so what should we do?

e: 2 options

  1. create another version e.g. 4.7.1 from github

  2. only change the version on pypi e.g. 4.7.1. it still output 4.7 instead of 4.7.1

e2: another update

i can't run pipx with buku because my mistake (unrelated to above)

it seem it is need to be deleted after all

> pipx install https://files.pythonhosted.org/packages/a2/b3/4076860a431b80cd1f22d69f9e643a3add4d45cadb9706de6d758beb3f9e/buku-4.7.tar.gz
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [20 lines of output]
      Traceback (most recent call last):
        File "/home/r3r/.local/pipx/shared/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
          main()
        File "/home/r3r/.local/pipx/shared/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/r3r/.local/pipx/shared/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 164, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
        File "/tmp/pip-build-env-ab3gkadw/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 44, in prepare_metadata_for_build_wheel
          builder = WheelBuilder(poetry)
        File "/tmp/pip-build-env-ab3gkadw/overlay/lib/python3.9/site-packages/poetry/core/masonry/builders/wheel.py", line 58, in __init__
          super(WheelBuilder, self).__init__(poetry, executable=executable)
        File "/tmp/pip-build-env-ab3gkadw/overlay/lib/python3.9/site-packages/poetry/core/masonry/builders/builder.py", line 85, in __init__
          self._module = Module(
        File "/tmp/pip-build-env-ab3gkadw/overlay/lib/python3.9/site-packages/poetry/core/masonry/utils/module.py", line 73, in __init__
          PackageInclude(
        File "/tmp/pip-build-env-ab3gkadw/overlay/lib/python3.9/site-packages/poetry/core/masonry/utils/package_include.py", line 22, in __init__
          self.check_elements()
        File "/tmp/pip-build-env-ab3gkadw/overlay/lib/python3.9/site-packages/poetry/core/masonry/utils/package_include.py", line 60, in check_elements
          raise ValueError(
      ValueError: /tmp/pip-req-build-d7ksb9_m/buku does not contain any element
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
Cannot determine package name from spec 'https://files.pythonhosted.org/packages/a2/b3/4076860a431b80cd1f22d69f9e643a3add4d45cadb9706de6d758beb3f9e/buku-4.7.tar.gz'. Check package spec for
errors.

@rachmadaniHaryono
Copy link
Collaborator

@rachmadaniHaryono rachmadaniHaryono commented on da64fdd Jul 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i decided to delete 4.7 release from pypi

it is already late here, so i will continue later

2 options:

i recommend to choose this

only change the version on pypi e.g. 4.7.1. it still output 4.7 instead of 4.7.1

after that release note and changelog have to be edited to mention this (changelog can be added on later commit but release note can be edited directly)

e: as note i also have to modify wiki about upload check later

@jarun
Copy link
Owner Author

@jarun jarun commented on da64fdd Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have uploaded the correct release. I have confirmed the changelog date. It is correct.

@jarun
Copy link
Owner Author

@jarun jarun commented on da64fdd Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. only change the version on pypi e.g. 4.7.1. it still output 4.7 instead of 4.7.1

This is fine.

@rachmadaniHaryono
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pypi.org/project/buku/4.7.1/

i only change version number on version line in buku file

wiki is updated. there is more step and file tree example

https://github.com/jarun/buku/wiki/Upload-to-pypi

sorry for this

@jarun
Copy link
Owner Author

@jarun jarun commented on da64fdd Jul 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey no problem! Thank you so much!

@eclipseo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done on Fedora.

@jarun
Copy link
Owner Author

@jarun jarun commented on da64fdd Jul 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please sign in to comment.