Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Certificate identification not working on MacOS #528

Closed
sysid opened this issue Aug 26, 2021 · 1 comment
Closed

SSL Certificate identification not working on MacOS #528

sysid opened this issue Aug 26, 2021 · 1 comment

Comments

@sysid
Copy link

sysid commented Aug 26, 2021

The following lines are failing on MacOS:

try:
    os.path.isfile('/etc/ssl/certs/ca-certificates.crt')
    CA_CERTS = '/etc/ssl/certs/ca-certificates.crt'
except Exception:
    import certifi
    CA_CERTS = certifi.where()

the expression os.path.isfile returns a bool and therefore the try/except clause is ineffective. On MacOS this results in the following error:

[ERROR] network_handler(): HTTPSConnectionPool(host='www.alexblackie.com', port=443): Max retries exceeded with url: /articles/email-authenticity-dkim-spf-dmarc/?utm_source=hackernewsletter&utm_medium=email&utm_term=fav (Caused by SSLError(FileNotFoundError(2, 'No such file or directory')))

@jarun
Copy link
Owner

jarun commented Aug 26, 2021

I don't own a Mac. If you can fix and confirm please raise a PR.

sysid added a commit to sysid/twbm that referenced this issue Aug 26, 2021
@jarun jarun closed this as completed in 110baff Oct 1, 2021
jarun added a commit that referenced this issue Oct 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants