Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bukuserver] Ignore spaces between commas #548

Closed
GreenLunar opened this issue Jan 6, 2022 · 7 comments · Fixed by #546
Closed

[bukuserver] Ignore spaces between commas #548

GreenLunar opened this issue Jan 6, 2022 · 7 comments · Fixed by #546

Comments

@GreenLunar
Copy link

Clicking on the first tag, gives a URL without + sign:
http://localhost:5001/bookmark/?flt2_tags_contain=brand%3Agnu
http://localhost:5001/bookmark/?flt2_tags_contain=+foundation%3Afree-software
http://localhost:5001/bookmark/?flt2_tags_contain=+free-software

@rachmadaniHaryono
Copy link
Collaborator

can you elaborate more?

@GreenLunar
Copy link
Author

The links listed above are from left to right. That's all.
If a Screencast would help, please let me know and I'll produce one.

@rachmadaniHaryono
Copy link
Collaborator

screencast

yes

@GreenLunar
Copy link
Author

I've just tried again and I didn't find anything like I've posted on the first post.
Perhaps it was because of the upper case letter.

Actually, when I open the links with + I get to see a space in the search form at its beginning " free-software".

I'm going to try to reproduce this.

@GreenLunar
Copy link
Author

I've reproduced!
I'm working on a screencast.

@GreenLunar
Copy link
Author

GreenLunar commented Jan 13, 2022

Steps to reproduce:
1. Click on the bookmarklet
1. Open the create new record dialog
2. Type spaces between commas.
3. Save bookmark before autocomplete takes effect.
* Each space is realized into a plus.

image
Press ASAP.

image
Before autocomplete is engaged.

simplescreenrecorder-2022-01-13_20.09.03.mkv.gz

@GreenLunar GreenLunar changed the title [bukuserver] Inconsistency on the first clickable tag [bukuserver] ignore spaces between commas Jan 13, 2022
@GreenLunar GreenLunar changed the title [bukuserver] ignore spaces between commas [bukuserver] Ignore spaces between commas Jan 13, 2022
@GreenLunar
Copy link
Author

Confirmed. Closing.

P.S. It was very very SLOOOOW, and I've only pressed Ctrl + V. Referring to #559

Pasting: tEstIng, Test , foOd , sTrong . StROnger,
image

Result
image

http://localhost:5001/bookmark/?flt2_tags_contain=strong++++++++.++++stronger <- This is good (even though its funny)

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants