bugfix bukuserver #546

rachmadaniHaryono · 2022-01-06T14:25:11Z

resolves #543
resolves #545
resolves #547
resolves #548
resolves #553
resolves #554
resolves #559

pre-commit
- update
- use local pylint
fix import server error on bukuserver.__main__
isort
- bukuserver.forms
- bukuserver.server
- bukuserver.views
- tests.test_buku
don't validate url, let buku do it
bukuserver
- use its own search_tag func
- use fork of flask-reverse-proxy-fix
pylint fix BookmarkletView too few public method
tests.test_buku
- merge test_parse_tags
- new test_parse_tags_no_args
simplify test_bookmark_model_view
flake8 add e203 for black compatilibityh
bukuserver.views
- handle unbound choosen_idx CustomAdminIndexView.search
- BookmarkModelView._apply_filters
  - remove unused flt_name var
  - handle no self._filters
- BookmarkModelView
  - _apply_filters
    - black formatted
    - dont manually check scheme validness
  - use buku.parse_tags on create_model and update_model
  - check arg when creating new bookmark record
- use single message on exception and error flash
- black formatted
- dont use favicon when there is no netloc

jarun · 2022-01-09T10:48:21Z

@rachmadaniHaryono anything left to be done here?

rachmadaniHaryono · 2022-01-09T11:07:30Z

#548, #547 could be here

i would decline #549 because it is feature request

i haven't see #543 and #553 yet

but no work for today, and maybe start from tomorrow

- use f string - don't use string as result variablee - black formatted

jarun · 2022-01-12T21:31:26Z

OK. Undraft when ready and please leave a note for me.

rachmadaniHaryono · 2022-01-12T21:34:22Z

while you are here please also read #484 (comment)

i need your opinion on that

- isort format - deduplicate parse_tags test case - test no args parse_tags

This reverts commit dd77595.

use hook config from example https://pylint.pycqa.org/en/latest/user_guide/pre-commit-integration.html?highlight=pre%20commit

rachmadaniHaryono · 2022-01-14T06:39:36Z

@GreenLunar can you confirm this pr work for your issue

if yes then @jarun can merge it if jarun agree with this pr

GreenLunar · 2022-01-14T10:46:49Z

It has been a while since I've utilized git.
Please tell me how to integrate this PR with the most recent master source archive.
Then, I'll test and report back.

rachmadaniHaryono · 2022-01-14T10:49:07Z

if you use pipx/pip you can download it from the zip

pipx install https://github.com/rachmadaniHaryono/Buku/archive/refs/heads/bugfix/ftp-link.zip

e: from source

> git remote add rachmadaniHaryono https://github.com/rachmadaniHaryono/Buku.git
> git checkout rachmadaniHaryono/bugfix/ftp-link

GreenLunar · 2022-01-14T13:10:51Z

Hi, I'll test and send a feedback. I'll be able to begin testing within 26 hours or so. I beg your pardon for my delay. I'll get to it ASAP.

rachmadaniHaryono · 2022-01-14T13:12:43Z

dont' worry and take your time

jarun · 2022-01-17T15:29:49Z

@rachmadaniHaryono

while you are here please also read #484 (comment)

i need your opinion on that

I am fine. Just ensure if someone wants to install only the cmdline part, she doesn't have to install everything.

rachmadaniHaryono · 2022-01-18T00:04:33Z

i added my fork of flask-reverse-proxy-fix so user don't have to manually install my fork

i also update note here #449

jarun · 2022-01-19T01:04:55Z

@rachmadaniHaryono OK to merge?

rachmadaniHaryono · 2022-01-19T01:10:49Z

i actually wait for @GreenLunar #546 (comment)

but it is already 5 day and ci is passed, so maybe merge it and close related issue

if there is bug please open new pr or reopen related issue

while you are here, i also make mistake by merging commit accidentally c09ecfb

so revert that commit before merging this pr

related #484 (comment)

GreenLunar · 2022-01-19T02:42:32Z

Apologies for the procrastination. I've got work tasks on my shoulders.
I'll dedicate the time for it, today. Within 24 hours from now, you'll get my report.

Again, sorry about it.

GreenLunar · 2022-01-20T02:38:38Z

Seems good

GreenLunar · 2022-01-20T09:33:19Z

Hi, I've tested all from a remote machine and all worked well.
I want to make more tests, and so I'm attempting to try this at home too.

Below are obstacles which I'm trying to resolve.

> git init
> git remote add rachmadaniHaryono https://github.com/rachmadaniHaryono/Buku.git
> git checkout rachmadaniHaryono/bugfix/ftp-link

$ git checkout rachmadaniHaryono/bugfix/ftp-link
error: pathspec 'rachmadaniHaryono/bugfix/ftp-link' did not match any file(s) known to git

I went on trying pipx for the first time:

$ bukuserver run --host 127.0.0.1 --port 5001
Traceback (most recent call last):
  File "/home/HOME/.local/bin/bukuserver", line 5, in <module>
    from bukuserver.server import cli
  File "/home/HOME/.local/pipx/venvs/buku/lib/python3.10/site-packages/bukuserver/server.py", line 12, in <module>
    from flask.cli import FlaskGroup
ModuleNotFoundError: No module named 'flask'

Trying to install dependencies leads me to this message: "No apps associated with package PACKAGE or its dependencies. If you are attempting to install a library, pipx should not be
used. Consider using pip or a similar tool instead."

e: Just in case:

$ pip install buku
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: buku in /usr/lib/python3.10/site-packages (4.6)
Requirement already satisfied: beautifulsoup4>=4.4.1 in /usr/lib/python3.10/site-packages (from buku) (4.10.0)
Requirement already satisfied: certifi in /usr/lib/python3.10/site-packages (from buku) (2021.10.8)
Requirement already satisfied: cryptography>=1.2.3 in /usr/lib/python3.10/site-packages (from buku) (36.0.1)
Requirement already satisfied: urllib3>=1.23 in /usr/lib/python3.10/site-packages (from buku) (1.26.7)
Requirement already satisfied: html5lib>=1.0.1 in /usr/lib/python3.10/site-packages (from buku) (1.1)
Requirement already satisfied: soupsieve>1.2 in /usr/lib/python3.10/site-packages (from beautifulsoup4>=4.4.1->buku) (2.2.1)
Requirement already satisfied: cffi>=1.12 in /usr/lib/python3.10/site-packages (from cryptography>=1.2.3->buku) (1.15.0)
Requirement already satisfied: pycparser in /usr/lib/python3.10/site-packages (from cffi>=1.12->cryptography>=1.2.3->buku) (2.21)
Requirement already satisfied: six>=1.9 in /usr/lib/python3.10/site-packages (from html5lib>=1.0.1->buku) (1.16.0)
Requirement already satisfied: webencodings in /usr/lib/python3.10/site-packages (from html5lib>=1.0.1->buku) (0.5.1)

$ pip install flask
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: flask in ./.local/lib/python3.10/site-packages (1.1.4)
Requirement already satisfied: Werkzeug<2.0,>=0.15 in ./.local/lib/python3.10/site-packages (from flask) (1.0.1)
Requirement already satisfied: click<8.0,>=5.1 in ./.local/lib/python3.10/site-packages (from flask) (7.1.2)
Requirement already satisfied: itsdangerous<2.0,>=0.24 in ./.local/lib/python3.10/site-packages (from flask) (1.1.0)
Requirement already satisfied: Jinja2<3.0,>=2.10.1 in ./.local/lib/python3.10/site-packages (from flask) (2.11.3)
Requirement already satisfied: MarkupSafe>=0.23 in /usr/lib/python3.10/site-packages (from Jinja2<3.0,>=2.10.1->flask) (2.0.1)

GreenLunar · 2022-01-20T11:00:06Z

@rachmadaniHaryono I've commented on the issues one by one. Please let me know if I've missed anything.

rachmadaniHaryono · 2022-01-21T23:16:18Z

based on this comment ¹ seem like you have difficulties getting my branch.

but after that you can get it working by this comment ².

so i assume this is working,

if not see below

> mkdir /tmp/tmp2
> cd /tmp/tmp2
> git clone https://github.com/rachmadaniHaryono/Buku.git
> cd Buku
> git checkout bugfix/ftp-link
> # add --force flag if necessary
> pipx install ".[server]"
> bukuserver run
> # after finished trying the branch
> pipx uninstall buku

this ³ should be fixed on ⁴

unfortunately for ⁵, i may have to put it on new pr

so basically if @GreenLunar think ³ is fixed at this point, this pr can be merged

for @jarun, can you check if sql command is correct on search_tag function in bukuserver.server module

e: note remind me to put above shell example on documentation

jarun · 2022-01-22T07:32:59Z

while you are here, i also make mistake by merging commit accidentally c09ecfb

done!

jarun · 2022-01-22T07:33:15Z

Thank you so much guys!

GreenLunar · 2022-01-22T18:26:10Z

based on this comment 1 seem like you have difficulties getting my branch.

but after that you can get it working by this comment 2.

so i assume this is working,

Yes, it's working and tested.

if not see below

> mkdir /tmp/tmp2
> cd /tmp/tmp2
> git clone https://github.com/rachmadaniHaryono/Buku.git
> cd Buku
> git checkout bugfix/ftp-link
> # add --force flag if necessary
> pipx install ".[server]"
> bukuserver run
> # after finished trying the branch
> pipx uninstall buku

As I recall, I've managed to install using pip.
Thanks. I'll follow the git steps for the next pull request.
As much as I dislike QA, I'll make more tests on the next pull request, again ;)

fix(bukuserver.views): ftp on valid scheme

aeec058

rachmadaniHaryono mentioned this pull request Jan 6, 2022

[bukuserver] ftp:// URIs are not clickable #545

Closed

rachmadaniHaryono marked this pull request as draft January 7, 2022 02:48

rachmadaniHaryono mentioned this pull request Jan 9, 2022

ToDo list #484

Open

97 tasks

fix(BookmarkModelView): update

e4ba8a7

- use f string - don't use string as result variablee - black formatted

rachmadaniHaryono changed the title ~~ftp link~~ bugfix bukuserver Jan 10, 2022

rachmadaniHaryono added 5 commits January 11, 2022 18:45

refactor(bukuserver.views): black format and pylint

1d42014

refactor(bukuserver.views): pyright

3a2c2ee

build(pre-commit): new hooks

bb1d6d3

refactor(bukuserver.views): isort

44be0e9

test(BookmarkModelView): simpler

9db41b7

rachmadaniHaryono added 4 commits January 13, 2022 21:08

test(buku): update

71a1274

- isort format - deduplicate parse_tags test case - test no args parse_tags

test(parse_tags): merge unittest

16b88db

fix(bukuserver.views): use buku parse_tags

4380537

refactor(bukuserver.views): unify msg between log and flash

b0ca0f5

rachmadaniHaryono force-pushed the bugfix/ftp-link branch from 0903669 to b0ca0f5 Compare January 13, 2022 13:58

rachmadaniHaryono added 10 commits January 13, 2022 22:03

build(pre-commit): autoupdate

7eb9e00

test(flake8): config

dd77595

Revert "test(flake8): config"

be0a9c8

This reverts commit dd77595.

test(flake8): config with tox.ini

4bcd21f

fix(bukuserver.__main__): import server

08fc444

build(pre-commit): hook darker

ea0c5cd

fix(ApiTagView): big tag list

ab14932

refactor(test_buku): revert unrelated code

bf7b223

build(pre-commit): hook pylint

be08fb9

use hook config from example https://pylint.pycqa.org/en/latest/user_guide/pre-commit-integration.html?highlight=pre%20commit

refactor(search_tag): type hint and simpler variable

b655d62

rachmadaniHaryono added 2 commits January 14, 2022 13:53

fix(BookmarkModelView): don't check scheme manually

8f318f1

fix(BookmarkModelView): dont get favicons if no netloc

f1d11b4

rachmadaniHaryono marked this pull request as ready for review January 14, 2022 06:38

rachmadaniHaryono added 2 commits January 18, 2022 07:55

build(bukuserver): use fixed version of flask-reverse-proxy-fix

af794a7

build(setup): add fork of flask-reverse-proxy-fix

f9eb421

build: flask-reverse-proxy-fix based on pep508

db698e8

rachmadaniHaryono mentioned this pull request Jan 18, 2022

bukuserver breaks with Werkzeug>1.0 #449

Closed

rachmadaniHaryono added 2 commits January 22, 2022 06:44

fix(BookmarkModelView): use buku method when creating bookmark

715d0c9

fix(BookmarkModelView): dont render tag with netloc when no netloc

ea6fdd8

jarun merged commit c7243ad into jarun:master Jan 22, 2022

rachmadaniHaryono mentioned this pull request Jan 22, 2022

[bukuserver] Load a specific set of tags upon autocomplete #559

Closed

rachmadaniHaryono deleted the bugfix/ftp-link branch January 22, 2022 19:44

github-actions bot locked and limited conversation to collaborators Feb 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bugfix bukuserver #546

bugfix bukuserver #546

rachmadaniHaryono commented Jan 6, 2022 •

edited

Loading

jarun commented Jan 9, 2022

rachmadaniHaryono commented Jan 9, 2022

jarun commented Jan 12, 2022

rachmadaniHaryono commented Jan 12, 2022

rachmadaniHaryono commented Jan 14, 2022 •

edited

Loading

GreenLunar commented Jan 14, 2022

rachmadaniHaryono commented Jan 14, 2022 •

edited

Loading

GreenLunar commented Jan 14, 2022

rachmadaniHaryono commented Jan 14, 2022

jarun commented Jan 17, 2022

rachmadaniHaryono commented Jan 18, 2022 •

edited

Loading

jarun commented Jan 19, 2022

rachmadaniHaryono commented Jan 19, 2022

GreenLunar commented Jan 19, 2022

GreenLunar commented Jan 20, 2022

GreenLunar commented Jan 20, 2022 •

edited

Loading

GreenLunar commented Jan 20, 2022

rachmadaniHaryono commented Jan 21, 2022 •

edited

Loading

jarun commented Jan 22, 2022

jarun commented Jan 22, 2022

GreenLunar commented Jan 22, 2022 •

edited

Loading

bugfix bukuserver #546

bugfix bukuserver #546

Conversation

rachmadaniHaryono commented Jan 6, 2022 • edited Loading

jarun commented Jan 9, 2022

rachmadaniHaryono commented Jan 9, 2022

jarun commented Jan 12, 2022

rachmadaniHaryono commented Jan 12, 2022

rachmadaniHaryono commented Jan 14, 2022 • edited Loading

GreenLunar commented Jan 14, 2022

rachmadaniHaryono commented Jan 14, 2022 • edited Loading

GreenLunar commented Jan 14, 2022

rachmadaniHaryono commented Jan 14, 2022

jarun commented Jan 17, 2022

rachmadaniHaryono commented Jan 18, 2022 • edited Loading

jarun commented Jan 19, 2022

rachmadaniHaryono commented Jan 19, 2022

GreenLunar commented Jan 19, 2022

GreenLunar commented Jan 20, 2022

GreenLunar commented Jan 20, 2022 • edited Loading

GreenLunar commented Jan 20, 2022

rachmadaniHaryono commented Jan 21, 2022 • edited Loading

Footnotes

jarun commented Jan 22, 2022

jarun commented Jan 22, 2022

GreenLunar commented Jan 22, 2022 • edited Loading

rachmadaniHaryono commented Jan 6, 2022 •

edited

Loading

rachmadaniHaryono commented Jan 14, 2022 •

edited

Loading

rachmadaniHaryono commented Jan 14, 2022 •

edited

Loading

rachmadaniHaryono commented Jan 18, 2022 •

edited

Loading

GreenLunar commented Jan 20, 2022 •

edited

Loading

rachmadaniHaryono commented Jan 21, 2022 •

edited

Loading

GreenLunar commented Jan 22, 2022 •

edited

Loading