Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] [bukuserver] Read Only Mode #549

Closed
GreenLunar opened this issue Jan 6, 2022 · 14 comments · Fixed by #631
Closed

[feature request] [bukuserver] Read Only Mode #549

GreenLunar opened this issue Jan 6, 2022 · 14 comments · Fixed by #631

Comments

@GreenLunar
Copy link

I read in several instances that the bukuserver is not for production, yet. I know.
bukuserver Web UI is useful even when it is in read-only mode, especially with portable devices, such as PDAs etc.

Please add a read-only mode to bukuserver.

@GreenLunar GreenLunar changed the title [bukuserver] Read Only Mode [feature request] [bukuserver] Read Only Mode Jan 12, 2022
@GreenLunar
Copy link
Author

GreenLunar commented Jan 13, 2022

FYI: I've opened a feature request at SearXNG and YaCy search engine projects.

@LeXofLeviafan
Copy link
Collaborator

…This one is pretty trivial, since flask-admin has direct support for disabling edit actions.

@jarun
Copy link
Owner

jarun commented Dec 3, 2022

Closing as doing it from the above layer makes more sense.

@jarun jarun closed this as completed Dec 3, 2022
@LeXofLeviafan
Copy link
Collaborator

doing it from the above layer

WDYM?

@jarun
Copy link
Owner

jarun commented Dec 3, 2022

From your comment my understanding was it can be done using some configuration provided by the flask framework. If that's not the case and code change is required, please reopen and raise the PR.

@LeXofLeviafan
Copy link
Collaborator

Ah… The disabling itself is done via BaseModelView fields, on per-model basis.

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Dec 3, 2022
@LeXofLeviafan
Copy link
Collaborator

(…As for reopening the issue, I don't seem to have the necessary access to do so – at least there doesn't seem to be such an action available in GitHub UI)

@rachmadaniHaryono
Copy link
Collaborator

just create pr and link to the issue, i will reopen it

@jarun
Copy link
Owner

jarun commented Dec 3, 2022

Thanks @rachmadaniHaryono!

@LeXofLeviafan I have added you as a collaborator. Please discuss before merging any PR and avoid direct pushes.

@LeXofLeviafan
Copy link
Collaborator

You know you can just disable direct pushes to master, right? :-)

@jarun
Copy link
Owner

jarun commented Dec 3, 2022

Sometimes I need that myself at wee hours for changes in the cli side.

@LeXofLeviafan
Copy link
Collaborator

In cases it's necessary I just re-enable direct pushes for a short time ;-)

@LeXofLeviafan
Copy link
Collaborator

…Might also be a good idea to set up mandatory approval before merging (though I seem to recall there being some bugs in GitHub related to this functionality).

@jarun
Copy link
Owner

jarun commented Dec 3, 2022

Ignore the admin stuff... let's get back to what matters.

@jarun jarun closed this as completed in #631 Dec 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants