Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags list in bukuserver is never recalculated #608

Closed
LeXofLeviafan opened this issue Nov 12, 2022 · 2 comments · Fixed by #628
Closed

Tags list in bukuserver is never recalculated #608

LeXofLeviafan opened this issue Nov 12, 2022 · 2 comments · Fixed by #628
Labels

Comments

@LeXofLeviafan
Copy link
Collaborator

After modifying tags on some bookmarks (i.e. removing old ones, adding brand new ones) and checking the tags page (/tag/) in bukuserver, I found out that it wasn't updated; moreover, after some experimentation I came to the conclusion that the only time tags list/usage counts is calculated is on server startup.

I believe there should be, at the very least, an option to trigger tags list recalculation without stopping the server (e.g. if it isn't recalculated automatically when opening the tags list, the tags page should have a button to recalculate it on demand).

@rachmadaniHaryono
Copy link
Collaborator

i can confirm this.

this is side effect from #594

2 things about this

  1. maybe only cache when bookmark under certain amount
  2. i agree with that button idea. something similar with like in statistic page

unfortunately i may not be able to work on bukuserver on the next few days, several issue like this and the one with css may need to wait

@jarun
Copy link
Owner

jarun commented Nov 17, 2022

It's fine. Take your time.

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Dec 1, 2022
@jarun jarun closed this as completed in #628 Dec 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants