Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use Optional type for every single argument with a default value #653

Closed
LeXofLeviafan opened this issue Dec 15, 2022 · 0 comments · Fixed by #660
Closed

Don't use Optional type for every single argument with a default value #653

LeXofLeviafan opened this issue Dec 15, 2022 · 0 comments · Fixed by #660
Labels
enhancement

Comments

@LeXofLeviafan
Copy link
Collaborator

The Optional type hint is meant to describe a "nullable" value – it has nothing to do with the value being an "omittable" function argument. Which is why I suggest modifying method type hints in the main buku file so that only the arguments which can legally have the None value are marked Optional.
@rachmadaniHaryono rachmadaniHaryono mentioned this issue Dec 19, 2022
Open
99 tasks
@LeXofLeviafan LeXofLeviafan mentioned this issue Dec 19, 2022
Closed
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 7, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
d9bbb1e 
…d some minor refactoring
@LeXofLeviafan LeXofLeviafan mentioned this issue Jan 7, 2023
Merged
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 7, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
e1cd1c8 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 7, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
21ff2b6 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 22, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
a3b4cea 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 22, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
6a6e8e6 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 22, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
8a7fa46 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 22, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
da189e5 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 22, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
3e01603 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
945481d 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
a85c1b7 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
6cb5c56 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
c183452 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
1f9cbfd 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
87a4d5b 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 23, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
690558d 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 27, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
f434bcd 
…d some minor refactoring
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jan 27, 2023
@LeXofLeviafan
[jarun#652][jarun#653] changed BookmarkVar into a namedtuple & applie…
f2dba20 
…d some minor refactoring
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bukudb] Various improvements LeXofLeviafan/buku
1 participant
@LeXofLeviafan