Feature/windows

[rachmadaniHaryono]

• use general Exception instead ImportError+ModuleNotFoundError, imo more expected result than adding ModuleNotFoundError to python3.5
• package requirement is taken from https://www.python.org/dev/peps/pep-0508/

i put do-not-merge label because i don't have windows dev to test it. the pr is actually finished except if there is another commit needed to fix problem from windows tester

[jarun]

@dertuxmalwieder would it be possible for you to confirm this?

[dertuxmalwieder]

According to the code, it should only behave differently on non-Windows platforms now...?

[jarun]

I think the only difference is it adds pyreadline as an additional dep on Windows.

@rachmadaniHaryono is pyreadline availabe by default on other platforms? Otherwise can we add it as a dep on all platforms?

[rachmadaniHaryono]

According to the code, it should only behave differently on non-Windows platforms now...?

yes, except if there is something wrong with what i write on general exception

I think the only difference is it adds pyreadline as an additional dep on Windows.

and also general exception on readline import error

@rachmadaniHaryono is pyreadline availabe by default on other platforms? Otherwise can we add it as a dep on all platforms?

i don't think so. based on pyreadline readme, it is actually only tested on windows 2000 and windows xp

The pyreadline package is a python implementation of GNU readline functionality it is based on the ctypes based UNC readline package by Gary Bishop. It is not complete. It has been tested for use with windows 2000 and windows xp.

[jarun]

It has been tested for use with windows 2000 and windows xp.

In that case, the change looks fine to me,

[jarun]

@dertuxmalwieder any update on this?

[dertuxmalwieder]

I haven’t tried my theory yet. ;-)
LGTM

[jarun]

@rachmadaniHaryono can we merge this? (labeled do-not-merge)

[rachmadaniHaryono]

yes, because @dertuxmalwieder said ok, i think it can be merged.

any related error on windows user can be fixed on another pr.

i will leave the label as it is. @jarun, you can change it if you want

[jarun]

Thank you guys!