Add support for bookmarks from Microsoft Edge #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integrated import of bookmarks from Microsoft Edge
integrate upstream changes and remove typos
jarun
requested changes
Jun 8, 2022
|
Hi @jarun I just applied the request changes. |
jarun
requested changes
Jun 9, 2022
|
I checked the |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jarun 👋
I integrated the import of bookmarks from Microsoft Edge (based on the already present functions required for Google Chrome). The two share the same chromium code base so adaption was rather easy.
However I'd like to point out that this PR is only tested on Windows 10 so far as I do not have access to a Linux or Mac OS computer.
Hope this might be helpful to you. Looking forward to your feedback.
Kind regards, Petra