Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bukuserver] Bookmark update error message #647

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

LeXofLeviafan
Copy link
Collaborator

fixes #646:

  • moving success logic on save (caching saved ID in session dict or raising an error on failure) out into a separate method
  • using said method in both create and update handlers to handle save logic
    note: flask-admin handles edit errors differently in debug and production mode

@rachmadaniHaryono
Copy link
Collaborator

as note this is test list i made for bukuserver

  • bookmarklet
    • test new url
      • test without any input
        • fetch
        • no fetch
      • test with selected text
    • test url already in db
  • bookmark
    • create
      • url only
      • fetch
      • no fetch
      • description
      • title
      • tag
    • delete
    • update
      • any
      • change url to another existing url
    • filter
  • tag
    • update
    • delete
    • filter
  • statistic
    • filter
      • netloc
      • tag
      • title

some issue fixed on #643 also tested using above test list

@LeXofLeviafan
Copy link
Collaborator Author

as note this is test list i made for bukuserver

I'm guessing you'll be adding this in a separate pull-request?

@jarun
Copy link
Owner

jarun commented Jan 5, 2023

@rachmadaniHaryono @LeXofLeviafan can this be merged?

@rachmadaniHaryono
Copy link
Collaborator

rachmadaniHaryono commented Jan 6, 2023

@jarun yes

e:

I'm guessing you'll be adding this in a separate pull-request?

yes @LeXofLeviafan , maybe here https://github.com/jarun/buku/wiki/PR-guidelines for now

@jarun jarun merged commit 11654e6 into jarun:master Jan 6, 2023
@jarun
Copy link
Owner

jarun commented Jan 6, 2023

Thank you!

@jarun
Copy link
Owner

jarun commented Jan 6, 2023

@LeXofLeviafan CI is failing. Please check.

@rachmadaniHaryono
Copy link
Collaborator

CI is failing. Please check.

as stated here https://github.com/orgs/Buku-dev/teams/dev/discussions/2/comments/7 i will take care of it

@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
@LeXofLeviafan LeXofLeviafan deleted the edit-failed-message branch August 24, 2024 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No clear indication of the bookmark edit being rejected in bukuserver
3 participants