Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session restore (s r) crash #1968

Closed
doremiyeon opened this issue Dec 12, 2024 · 2 comments · Fixed by #1969
Closed

session restore (s r) crash #1968

doremiyeon opened this issue Dec 12, 2024 · 2 comments · Fixed by #1969

Comments

@doremiyeon
Copy link
Contributor

nnn/src/nnn.c

Line 4546 in 5e5a17f

xstrsncpy(curssn, sname, NAME_MAX);

when attempting to restore a session by hitting 's r', sname is NULL here. should probably check for that and write @\0 to curssn.
@jarun
Copy link
Owner

jarun commented Dec 12, 2024

Raise a PR please.

doremiyeon added a commit to doremiyeon/nnn that referenced this issue Dec 13, 2024
@doremiyeon
fix 's r' session restore jarun#1968
395068d
@doremiyeon
Copy link
Contributor Author

#1969 here you go, sorry.

jarun added a commit that referenced this issue Dec 13, 2024
@jarun
Merge pull request #1969 from doremiyeon/us1968_session_restore_fix
f87104d 
fix 's r' session restore #1968
@N-R-K N-R-K linked a pull request Dec 14, 2024 that will close this issue
fix 's r' session restore #1968 #1969
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 's r' session restore #1968 doremiyeon/nnn
2 participants
@jarun @doremiyeon