Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for common elixir extensions #1419

Closed
wants to merge 1 commit into from

Conversation

skbolton
Copy link

@skbolton skbolton commented Jul 8, 2022

eex and heex are for elixirs templating languages
exs is for elixir scripts
ex is the common extension for files

eex and heex are for elixirs templating languages
exs is for elixir scripts
ex is the common extension for files
@jarun
Copy link
Owner

jarun commented Jul 8, 2022

Sorry, please patch locally.

@jarun jarun closed this Jul 8, 2022
@skbolton
Copy link
Author

skbolton commented Jul 8, 2022

I can go about this route but I think its worth calling out that the codebase has references to icons that it doesn't inject. Should I PR something that removes a reference to an elixir icon?

# define MFIZZ_ELIXIR "\uedc4"

@jarun
Copy link
Owner

jarun commented Jul 8, 2022

Those come from the standard headers and as long as you don't use them, they don't take up memory.
As soon as you use them you add 2 overheads for people who don't need them:

  • memory
  • time spent in comparing the extensions

@skbolton skbolton deleted the add-elixir-icon branch July 8, 2022 17:26
@skbolton skbolton restored the add-elixir-icon branch July 12, 2022 02:05
@jarun jarun mentioned this pull request Jul 25, 2022
@N-R-K
Copy link
Collaborator

N-R-K commented Jul 25, 2022

This got added in #1437

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants