-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust icons #1502
Add Rust icons #1502
Conversation
@N-R-K or @luukvbaal please review. If all icons supported are covered feel free to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is it just my setup or is the rust icon a bit too small to be visually distinguishable? But then again, the c++ icon is pretty hard to distinguish from the C icon as well, so 🤷 @gaoDean does the icon appear well on your setup? The above screenshot is with |
@N-R-K yeah it is a bit small, but that's a nerdfont problem. |
@N-R-K can you please check the build failure? |
CI... |
Sure, but I'm getting a 403 error when I try to view the CI logs... |
I can view it just fine. On master this is what I get:
Other than that it's complaining about |
I'll need some time to get bk to my laptop. |
Hello, I don't know if I'm just missing something, but I saw that there was rust support in the
icons-in-terminal.h
but it wasn't used, so I added this and the nerd-font equivalent to theicons.h
.