Support more trash utility #1831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support sindresorhus/macos-trash, which just moves files/folders to the macOS native trash bin. Setting `NNN_TRASH=3` makes nnn use `trash` command to delete files.
N-R-K
requested changes
Feb 25, 2024
There was a problem hiding this comment.
I don't think we want to keep hardcoding more and more trash utils. Instead making NNN_TRASH=3 call out to some specific plugin is more flexible (see #1811 (comment)).
|
You're right. Thanks and I'll close the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add more options for the environment variable
NNN_TRASH.Currently,
NNN_TRASHonly support two external utilities:1fortrash-putin andreafrancia/trash-cli,2forgio trash. These two doesn't seem to act perfectly in macOS.In macOS, there are trash utilities like sindresorhus/macos-trash and trash, which just move files/folders to the native trash bin. The two utilities can be installed with:
These two both provide the command interface
trash. They are useful when an user prefer to use the native trash folder.Thanks for your review.