Do not default to xterm
#1935
Merged
Do not default to xterm
#1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes more sense to default to the terminals people are less likely to have. If a user has `xterm` installed, then that is, most probably, because it ships with X11. Whereas if a user has `st` or `alacritty` instlled, then that is because he/she chose to install it.
|
@N-R-K or @luukvbaal can one of you please address the CI failures? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes more sense to default to the terminals people are less likely to have. If a user has
xterminstalled, then that is, most probably, because it ships with X11. Whereas if a user hasstoralacrittyinstlled, then that is because he/she chose to install it.