Indicate type-to-nav mode with symbol F #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarun
requested changes
Sep 23, 2024
jarun
requested changes
Sep 23, 2024
amalgame21
force-pushed
the
type-to-nav-indicator
branch
from
184335f
to
c291932
Compare
amalgame21
changed the title
|
Thank you! |
N-R-K
reviewed
Sep 24, 2024
| @@ -3238,6 +3238,9 @@ static int getorderstr(char *sort) | |||
| { | |||
| int i = 0; | |||
|
|
|||
| if (cfg.filtermode) | |||
| sort[i++] = 'F'; | |||
There was a problem hiding this comment.
Is this the right place to add this though? This string is related to sorting, but type to nav mode isn't really related to sorting order.
There was a problem hiding this comment.
True but it's the smallest patch. :)
There was a problem hiding this comment.
Sorry I don't understand the code design very much and I just hacked it with my very very limited knowledge in C. If it is not the proper place to add this code and mess thing up please reverse it. Local patch is easy.
There was a problem hiding this comment.
I have taken care of it. The code is better placed now.
There was a problem hiding this comment.
Thanks! Really appreciated!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify the user the current context menu is in type-to-nav mode with symbol N after pressing
ESCin type-to-nav mode.After pressing
^N, the symbol N disappear, indicate it is no longer in type-to-nav mode.Feel free to reject it if it does not match nnn's design.