Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle type-to-nav (^N) like global switch #1938

Closed

Conversation

amalgame21
Copy link
Contributor

@amalgame21 amalgame21 commented Sep 22, 2024

This commit bring the current type-to-nav mode state to next context while changing to the next context, making toggling the type-to-nav (^N) like a global switch, instead of the original behavior which store each type-to-nav mode state per context.

I think it is much easier to control the workflow because I no longer need to remember which context is in type-to-nav mode or not.

Feel free to reject it if it does not match nnn's design.

This commit bring the current type-to-nav mode state to next context while changing to the next context, making toggling the type-to-nav (^N) like a global switch, instead of the original behavior which store each type-to-nav mode state per context.
@jarun
Copy link
Owner

jarun commented Sep 23, 2024

It's not about design, a use case would be broken.

When we create the context, the type-to-nav feature is also enabled. So if it's disabled for a context, it's because the user has decided to disable it explicitly. We can't override that every time there is a context switch because in that case there would be now simple way to switch contexts without disabling type-to-nav.

@jarun jarun closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants