Remove remaining jQuery from View tests #3073

akre54 · 2014-03-18T23:03:06Z

Now that #3003 is merged, we need an easy way for alternative View implementations to run against our View conformance test. This pulls jQuery out of the View tests except in for checking view.$el instanceof Backbone.$ (which all jQuery-like apis should support).

eastridge · 2014-03-19T01:06:32Z

@akre54 should Backbone.Nativeview provide a Backbone.$ to check against?

akre54 · 2014-03-19T01:17:46Z

Why? It's not present and not needed.

eastridge · 2014-03-19T01:25:10Z

"which all jQuery-like apis should support" was what made me think of that, but I guess it's not really a jQuery API, but something that makes Backbone not need jQuery

wyuenho · 2014-03-19T06:43:30Z

test/view.js

      initialize: function() {
-        this.listenTo(this.model, 'all x', function(){ ok(false); });
-        this.listenTo(this.collection, 'all x', function(){ ok(false); });
+        this.listenTo(this.model, 'all x', function(){ ok(false); }, this);


We don't need the this in the end.

Good catch. Thanks.

wyuenho · 2014-03-19T14:37:56Z

Mind if I refactor the dispatchEvent shim and fix the custom event test?

akre54 · 2014-03-19T14:42:30Z

Go for it. Not sure why Travis is throwing a fit. Maybe we have to expose CustomEvent from window?

wyuenho · 2014-03-19T14:45:02Z

Nah, non-standard custom events just need to be created in a special way.

https://developer.mozilla.org/en/docs/Web/API/CustomEvent

braddunbar · 2014-03-19T14:59:05Z

Take a look at #3077. I think that sort of thing will make this process much easier.

akre54 · 2014-03-19T22:21:12Z

@braddunbar reverted View -> Backbone.View changes, and removed the setup method which was only being used to test the constructor. As long as the view implementation keeps a reference to Backbone.View (if needed), it should be fine to reassign to Backbone.View for testing purposes.

wyuenho · 2014-04-04T17:48:16Z

This looks good to me. It turns out there wasn't an easy way to fire a custom event on IE<=8.

Also, in case anyone is wondering why there's a click function, ariya/phantomjs#10795 is why.

wyuenho · 2014-06-17T16:39:15Z

Hey guys, can this be merged or is there something else you think we should do?

braddunbar · 2014-06-17T16:44:15Z

I do not think this one should be merged. From @jashkenas in #3077:

While I appreciate the sentiment, having a sanity test that Backbone View events are continuing to work properly with jQuery seems like a wise idea. It's not just about use testing the contract — it's also about being warned early if anything funny happens in future versions of jQuery (as has happened before).

I think we should be testing the real thing, not just that the arguments we pass are the arguments we pass.

Testing via mocked event creation is certainly not the real thing. Further, it somewhat obscures the contract.

akre54 · 2014-06-17T19:28:14Z

Testing via mocked event creation is certainly not the real thing

How is this different from what we have now with $el.trigger('click')?

Tests aren't the place to catch issues with the latest jQuery. We've faced it before (with PATCH support, e.g.), and there almost always is a reasonable solution. Specs should never test your dependencies.

braddunbar · 2014-06-17T19:43:39Z

How is this different from what we have now with $el.trigger('click')?

jQuery#trigger is tested and used in real application code and a one-off implementation in our test suite isn't?

Tests aren't the place to catch issues with the latest jQuery. We've faced it before (with PATCH support, e.g.), and there almost always is a reasonable solution. Specs should never test your dependencies.

I'd prefer contract only tests in this case but using a trusted and tested library like jQuery is certainly better than an untested implementation written just for our tests.

akre54 · 2014-06-17T20:21:38Z

Totally, and I can appreciate that. But this isn't some far-out custom code that we just pulled out of thin air. jQuery's code itself is more synthetic than what we're doing here since its on/trigger lifecycle lives entirely within the jQuery realm. Triggering a MouseEvent directly is much closer to what we're actually trying to test here (jquery itself uses elem.click() to trigger events bound outside of $.fn.on).

akre54 · 2014-06-17T21:05:32Z

test/view.js

+  };
+
+  function click(element) {
+    var event;


Hey @wyuenho, how come we couldn't just use element.click() directly here? It'd obviate this messiness here. Only downside I see is that the element would have to live in the DOM already.

ariya/phantomjs#10795

We can and should get rid of the click shim as soon as that phantom bug gets fixed. Either that or we use a different test runner like Karma that actually tests on real browsers.

Yeah it might be nice to get something like Sauce labs testing in here too since we're concerned about older browsers.

Shame about that bug though.

akre54 · 2015-02-17T18:14:50Z

@braddunbar want to take one final pass through this and then either merge or close? I'm fine either way.

wyuenho · 2015-04-12T08:39:42Z

@akre54 Has PhantomJS 2 fixed this click event issue?

wyuenho reviewed Mar 19, 2014
View reviewed changes

akre54 added the enhancement label Mar 19, 2014

braddunbar mentioned this pull request Mar 19, 2014

Test the delegate interface. #3077

Closed

akre54 added 11 commits March 23, 2014 02:01

remove remaining jQuery from View tests

54b79e4

use native CustomEvent constructor for DOM element

10c0b2e

remove superfluous this from listento

235fcc9

break out trigger shim

93b3eb5

fix typo

e4e5852

shorter filterer fn with findWhere

9b2081f

remove extra Backbone.$ checks

ec57467

change back View -> Backbone.View

71ce73e

remove setup method

aecb76c

remove extra lines and small fixes

f724fa1

wrap custom events test in a Backbone.$ check

2efebb3

akre54 reviewed Jun 17, 2014
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove remaining jQuery from View tests #3073

Remove remaining jQuery from View tests #3073

akre54 commented Mar 18, 2014

eastridge commented Mar 19, 2014

akre54 commented Mar 19, 2014

eastridge commented Mar 19, 2014

wyuenho Mar 19, 2014

akre54 Mar 19, 2014

wyuenho commented Mar 19, 2014

akre54 commented Mar 19, 2014

wyuenho commented Mar 19, 2014

braddunbar commented Mar 19, 2014

akre54 commented Mar 19, 2014

wyuenho commented Apr 4, 2014

wyuenho commented Jun 17, 2014

braddunbar commented Jun 17, 2014

akre54 commented Jun 17, 2014

braddunbar commented Jun 17, 2014

akre54 commented Jun 17, 2014

akre54 Jun 17, 2014

wyuenho Jun 17, 2014

akre54 Jun 17, 2014

akre54 commented Feb 17, 2015

wyuenho commented Apr 12, 2015

Remove remaining jQuery from View tests #3073

Are you sure you want to change the base?

Remove remaining jQuery from View tests #3073

Conversation

akre54 commented Mar 18, 2014

eastridge commented Mar 19, 2014

akre54 commented Mar 19, 2014

eastridge commented Mar 19, 2014

wyuenho Mar 19, 2014

Choose a reason for hiding this comment

akre54 Mar 19, 2014

Choose a reason for hiding this comment

wyuenho commented Mar 19, 2014

akre54 commented Mar 19, 2014

wyuenho commented Mar 19, 2014

braddunbar commented Mar 19, 2014

akre54 commented Mar 19, 2014

wyuenho commented Apr 4, 2014

wyuenho commented Jun 17, 2014

braddunbar commented Jun 17, 2014

akre54 commented Jun 17, 2014

braddunbar commented Jun 17, 2014

akre54 commented Jun 17, 2014

akre54 Jun 17, 2014

Choose a reason for hiding this comment

wyuenho Jun 17, 2014

Choose a reason for hiding this comment

akre54 Jun 17, 2014

Choose a reason for hiding this comment

akre54 commented Feb 17, 2015

wyuenho commented Apr 12, 2015