Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _.restArgs #3562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use _.restArgs #3562

wants to merge 1 commit into from

Conversation

jridgewell
Copy link
Collaborator

A starting PR for using _.restArgs. I'll update once Underscore officially releases it.

@akre54
Copy link
Collaborator

akre54 commented Apr 15, 2015

Mind throwing up a quickie jsperf to show the hit isn't too terrible?

@jridgewell
Copy link
Collaborator Author

Mind throwing up a quickie jsperf to show the hit isn't too terrible?

Here's #trigger.

@akre54
Copy link
Collaborator

akre54 commented Apr 15, 2015

Cool, looks good. I'm gonna hold off on merging until we get an Underscore release and fix the failing tests.

@jridgewell
Copy link
Collaborator Author

Cool, looks good. I'm gonna hold off on merging until we get an Underscore release and fix the failing tests.

Yup, that's what I was waiting for too. Just using this PR as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jridgewell @akre54 @jashkenas